Allow creating UDP sockets on iOS #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Ok, but why? Are you guys use these functions directly without any shadowsocks protocol encapsulation? |
pinkisemils
commented
May 17, 2023
Contributor
Author
pinkisemils
left a comment
pinkisemils
left a comment
There was a problem hiding this comment.
The crate just won't compile without exposing these modules for iOS targets.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
pinkisemils
force-pushed
the
add-ios-support
branch
2 times, most recently
from
8365bc1 to
5107e53
Compare
pinkisemils
force-pushed
the
add-ios-support
branch
from
5107e53 to
1ea24a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just added support for building and running ShadowSocks on iOS. We've used it as a library, and it works well enough for our usecase. Would be great to see this upstreamed.
This change is